Roll ranges for constant and variable stats displayed inconsistently
Device: All
Browser: All
OS: All
Hi, this is a great site! I use it to look up any item that I find during gameplay. I find the visual display of information to be very concise and useful.
I've found two small inconsistencies in how the information is presented, though, and wanted to report them to help make the site even better. I'm not sure if you want these in separate threads or not, but I'm posting them here because they seem closely related.
1. Constant stats for some items are displayed as variable stats
Whenever there's a range of any kind in a stat, the site displays it as a variable stat (the green box around it, and the <code title="Variable stat or range"> tag around it).
One quick example of this is the Raven Frost. You can see that the "15-45" in "Adds 15-45 Cold Damage, 4 sec. Duration" is displayed with a green box around it to indicate a variable stat, even though this is the same on every Raven Frost ring.
2. Variable stats are displayed as constant
Variable stats are displayed as constant in some fields. I've only noticed it in the defense and dmg fields, but it's possible that it's happening in other fields.
One example that shows both of the issues in one item is the Monarch. The Defense stat and the Paladin Smite Dmg stat are both displayed the in the same way (with no green box), even though the Defense stat is variable, and the Paladin Smite Dmg is constant (it is a range of damage, but it's always the same range for that item).
I would expect the defense stat to be displayed as variable, and the Paladin Smite Dmg to remain as is.
6
replies
1004 views
Description
Device: All
Browser: All
OS: All
Hi, this is a great site! I use it to look up any item that I find during gameplay. I find the visual display of information to be very concise and useful.
I've found two small inconsistencies in how the information is presented, though, and wanted to report them to help make the site even better. I'm not sure if you want these in separate threads or not, but I'm posting them here because they seem closely related.
1. Constant stats for some items are displayed as variable stats
Whenever there's a range of any kind in a stat, the site displays it as a variable stat (the green box around it, and the <code title="Variable stat or range"> tag around it).
One quick example of this is the Raven Frost. You can see that the "15-45" in "Adds 15-45 Cold Damage, 4 sec. Duration" is displayed with a green box around it to indicate a variable stat, even though this is the same on every Raven Frost ring.
2. Variable stats are displayed as constant
Variable stats are displayed as constant in some fields. I've only noticed it in the defense and dmg fields, but it's possible that it's happening in other fields.
One example that shows both of the issues in one item is the Monarch. The Defense stat and the Paladin Smite Dmg stat are both displayed the in the same way (with no green box), even though the Defense stat is variable, and the Paladin Smite Dmg is constant (it is a range of damage, but it's always the same range for that item).
I would expect the defense stat to be displayed as variable, and the Paladin Smite Dmg to remain as is.
Description by Browser: All
OS: All
Hi, this is a great site! I use it to look up any item that I find during gameplay. I find the visual display of information to be very concise and useful.
I've found two small inconsistencies in how the information is presented, though, and wanted to report them to help make the site even better. I'm not sure if you want these in separate threads or not, but I'm posting them here because they seem closely related.
1. Constant stats for some items are displayed as variable stats
Whenever there's a range of any kind in a stat, the site displays it as a variable stat (the green box around it, and the <code title="Variable stat or range"> tag around it).
One quick example of this is the Raven Frost. You can see that the "15-45" in "Adds 15-45 Cold Damage, 4 sec. Duration" is displayed with a green box around it to indicate a variable stat, even though this is the same on every Raven Frost ring.
2. Variable stats are displayed as constant
Variable stats are displayed as constant in some fields. I've only noticed it in the defense and dmg fields, but it's possible that it's happening in other fields.
One example that shows both of the issues in one item is the Monarch. The Defense stat and the Paladin Smite Dmg stat are both displayed the in the same way (with no green box), even though the Defense stat is variable, and the Paladin Smite Dmg is constant (it is a range of damage, but it's always the same range for that item).
I would expect the defense stat to be displayed as variable, and the Paladin Smite Dmg to remain as is.
duotrig
Can be used to make Runewords:
Hey, that's a known issue, as I think the code detects the string "a - b" as a range in any case, but I will let our admin answer more precisely. Not sure it's easy t fix, though it is indeed a bit annoying.
Main: Necromancer / Second: Assassin / Third: Amazon / Check my stash tabs
Hi! Do you know if there's already another thread for it? I couldn't find one, but I'm happy to move there if needed.
Not that I remember, but don't worry, Teebs if he manages to fix will clean all corresponding entries
Main: Necromancer / Second: Assassin / Third: Amazon / Check my stash tabs
Another thread related to the variable look, which includes a comment from Teebling: bug-reports/phoenix-item-desc-t1606654.html
My grail tracker is for offline SC. I also play offline HC and recently some occasional online SC NL.
Is there an established way to help fix these kind of bugs (like with an open source project)? I'm a professional web developer and would be happy to take a look at the codebase to see if there's a viable fix.
@Teebling you have previously mentioned (in the other thread about Phoenix) that you're using a regex to match ranges.
Could you tell us what the regex is, and perhaps we can help suggest improvements?
You could incorporate zero-width lookbehind assertions to ensure the matched range is not fixed damage ranges. (they all follow the Pattern of "Adds X-Y [Damage Type] Damage")
For example, if you're using something like this:
You could change it to something like this:
Could you tell us what the regex is, and perhaps we can help suggest improvements?
You could incorporate zero-width lookbehind assertions to ensure the matched range is not fixed damage ranges. (they all follow the Pattern of "Adds X-Y [Damage Type] Damage")
For example, if you're using something like this:
\w+-\w+ (just a guess based on the fact that Phoenix shield is highlighting the word "Level-up" as a range).You could change it to something like this:
(?<!Adds )(?<!\d)\d+(\.\d+)?-\d+(\.\d+)?\dinstead of\wto match only digits and not all word characters\d+(\.\d+)?instead of just\d+to support decimal values (like on Grief's +X% Damage To Demons, which is displayed incorrectly right now)(?<!Adds )(the first negative lookbehind) to ensure the range is not immediately preceded by "Adds ", which signals a fixed damage range(?<!\d)(the second negative lookbehind) to ensure that the first negative lookbehind does not consume the first digit in the range (lookbehinds are greedy)
Test result
This is how it would appear:
Phoenix:
4 socket Weapons
100% Chance To Cast level 40 Blaze When You Level Up
40% Chance To Cast Level 22 Firestorm On Striking
Level
+
Ignores Target's Defense
14% Mana Stolen Per Hit
-28% To Enemy Fire Resistance
20% Deadly Strike
+
+
4 socket Shields
100% Chance To Cast level 40 Blaze When You Level-up
40% Chance To Cast Level 22 Firestorm On Striking
Level
+
+
-28% To Enemy Fire Resistance
+50 To Life
+5% To Maximum Lightning Resist
+10% To Maximum Fire Resist
+
Grief:
35% Chance To Cast Level 15 Venom On Striking
+
Damage +
Ignore Target's Defense
-25% Target Defense
+(1.875 per character level)
Adds 5-30 Fire Damage
-
20% Deadly Strike
Prevent Monster Heal
+2 To Mana After Each Kill
+
Astreon's Iron Ward:
+
Damage +
+50% Damage To Undead
Adds 80-240 Magic Damage
33% Chance of Crushing Blow
Slows Target By 25%
Damage Reduced By
+
+10% Increased Attack Speed
Raven Frost:
+
Adds 15-45 Cold Damage, 4 sec. Duration
Cannot Be Frozen
+
+40 To Mana
Cold Absorb 20%
Lightsabre:
+
Adds 10-30 Damage
Adds 60-120 Magic Damage
Adds 1-200 Lightning Damage
5% Chance To Cast Level
20% Increased Attack Speed
Ignore Target's Defense
Lightning Absorb 25%
+7 To Light Radius
Phoenix:
4 socket Weapons
100% Chance To Cast level 40 Blaze When You Level Up
40% Chance To Cast Level 22 Firestorm On Striking
Level
10-15 Redemption Aura When Equipped+
350-400% Enhanced DamageIgnores Target's Defense
14% Mana Stolen Per Hit
-28% To Enemy Fire Resistance
20% Deadly Strike
+
350-400 Defense Vs. Missile+
15-21 Fire Absorb4 socket Shields
100% Chance To Cast level 40 Blaze When You Level-up
40% Chance To Cast Level 22 Firestorm On Striking
Level
10-15 Redemption Aura When Equipped+
350-400 Defense Vs. Missile+
350-400% Enhanced Damage-28% To Enemy Fire Resistance
+50 To Life
+5% To Maximum Lightning Resist
+10% To Maximum Fire Resist
+
15-21 Fire AbsorbGrief:
35% Chance To Cast Level 15 Venom On Striking
+
30-40% Increased Attack SpeedDamage +
340-400Ignore Target's Defense
-25% Target Defense
+(1.875 per character level)
1.875-185.625% Damage To Demons (Based on Character Level)Adds 5-30 Fire Damage
-
20-25% To Enemy Poison Resistance20% Deadly Strike
Prevent Monster Heal
+2 To Mana After Each Kill
+
10-15 Life After Each KillAstreon's Iron Ward:
+
240-290% Enhanced DamageDamage +
40-85+50% Damage To Undead
Adds 80-240 Magic Damage
33% Chance of Crushing Blow
Slows Target By 25%
Damage Reduced By
4-7+
2-4 To Combat Skills (Paladin Only)+10% Increased Attack Speed
150-200% Bonus To Attack RatingRaven Frost:
+
150-250 To Attack RatingAdds 15-45 Cold Damage, 4 sec. Duration
Cannot Be Frozen
+
15-20 To Dexterity+40 To Mana
Cold Absorb 20%
Lightsabre:
+
150-200% Enhanced DamageAdds 10-30 Damage
Adds 60-120 Magic Damage
Adds 1-200 Lightning Damage
5-7% Mana Stolen Per Hit5% Chance To Cast Level
14-20 Chain Lightning On Attack20% Increased Attack Speed
Ignore Target's Defense
Lightning Absorb 25%
+7 To Light Radius
I'm in CET (Central European Time), so that's UTC+1 normally and UTC+2 during DST.
My profile says Ladder, but I play both Ladder and Non-Ladder.
My profile says Softcore, but I play both Softcore and Hardcore.
My Holy Grail Tracker is for Offline Hardcore.
My profile says Ladder, but I play both Ladder and Non-Ladder.
My profile says Softcore, but I play both Softcore and Hardcore.
My Holy Grail Tracker is for Offline Hardcore.
Similar pages
Advertisment
Hide ads
Greetings stranger!
You don't appear to be logged in...No matches
duotrig
1