Notification not received for second like action from same user
1
reply
531 views
Description
OS & Browser: Mac OS X High Sierra, Safari Version 13.1.2
Location on site: Global issue
Description of bug: You only receive a notification for the first 'like' given by a user sometimes.
Steps to reproduce: Like two posts of the same author from the same account, and observe that only one notification is produced (for the first like action).
Any further information: Please see relevant bug report tickets on phpBB and on Github.
Description by 
Teebling
Can be used to make Runewords:
OS & Browser: Mac OS X High Sierra, Safari Version 13.1.2
Location on site: Global issue
Description of bug: You only receive a notification for the first 'like' given by a user sometimes.
Steps to reproduce: Like two posts of the same author from the same account, and observe that only one notification is produced (for the first like action).
Any further information: Please see relevant bug report tickets on phpBB and on Github.
Fixed•Go to post
As I suspected it seems that the original fix for this was overwritten at some point during development, so the old bug snuck back in. I looked at what the original dev changed back in 2015 when he released version 1.0.2.137 and re-applied the changes to my current master version (2.0.0-b3) and now all the notifications are showing 
For anyone wanting a find & replace solution here's how to do it:
In /ext/anavaro/postlove/notifications/postlove.php:
Find:
Replace with:
Find:
Replace with:
For anyone wanting a find & replace solution here's how to do it:
In /ext/anavaro/postlove/notifications/postlove.php:
Find:
Code: Select all
public static function get_item_id($data)
{
return (int) $data['requester_id'];
}Code: Select all
public static function get_item_id($data)
{
return (int) $data['post_id'];
}Code: Select all
public static function get_item_parent_id($data)
{
return (int) $data['post_id'];
}Code: Select all
public static function get_item_parent_id($data)
{
return (int) $data['requester_id'];
}
As I suspected it seems that the original fix for this was overwritten at some point during development, so the old bug snuck back in. I looked at what the original dev changed back in 2015 when he released version 1.0.2.137 and re-applied the changes to my current master version (2.0.0-b3) and now all the notifications are showing For anyone wanting a find & replace solution here's how to do it:
In /ext/anavaro/postlove/notifications/postlove.php:
Find:
Replace with:
Find:
Replace with:
This post was marked as the fix. For anyone wanting a find & replace solution here's how to do it:
In /ext/anavaro/postlove/notifications/postlove.php:
Find:
Code: Select all
public static function get_item_id($data)
{
return (int) $data['requester_id'];
}Code: Select all
public static function get_item_id($data)
{
return (int) $data['post_id'];
}Code: Select all
public static function get_item_parent_id($data)
{
return (int) $data['post_id'];
}Code: Select all
public static function get_item_parent_id($data)
{
return (int) $data['requester_id'];
}Similar pages
Advertisment
Hide ads
Greetings stranger!
You don't appear to be logged in...No matches
Teebling
5807Admin